[Release-4.21] OCPBUGS-81993,OCPBUGS-81994: Bump github.com/go-jose/go-jose/v4 to 4.1.4 by MrSanketkumar · Pull Request #718 · openshift/operator-framework-operator-controller

MrSanketkumar · 2026-05-07T11:31:09Z

Summary by CodeRabbit

Chores
- Updated a cryptographic library dependency to its latest patch version for improved stability and security.

openshift-ci-robot · 2026-05-07T11:31:17Z

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-81994, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-84410 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-84410 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-07T11:31:19Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 00f4cbbf-7734-4b3d-a7fe-6f01d34a83a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Walkthrough

Two Go module files are updated to upgrade the indirect dependency github.com/go-jose/go-jose/v4 from version v4.1.3 to v4.1.4 in the root module and in the openshift/default-catalog-consistency submodule.

Changes

Dependency Version Update

Layer / File(s)	Summary
go-jose/v4 dependency bump `go.mod`, `openshift/default-catalog-consistency/go.mod`	Indirect dependency `github.com/go-jose/go-jose/v4` updated from `v4.1.3` to `v4.1.4` in both the root and submodule `go.mod` files.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: bumping the github.com/go-jose/go-jose/v4 dependency to version 4.1.4, with release and bug reference context.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR only updates Go module dependencies in go.mod/go.sum files. No Ginkgo test files are modified, making the test naming check not applicable to this PR.
Test Structure And Quality	✅ Passed	This PR only modifies go.mod files to update a dependency version. The repository uses testify for testing, not Ginkgo. There are no Ginkgo tests to review, so the custom check is not applicable.
Microshift Test Compatibility	✅ Passed	PR adds standard Go e2e tests (func Test*), not Ginkgo tests (It/Describe/Context/When). Custom check targets Ginkgo tests only, so not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR only updates go-jose/v4 dependency in go.mod files. No new Ginkgo e2e tests are added. The custom check only applies when tests are added, so not applicable here.
Topology-Aware Scheduling Compatibility	✅ Passed	PR contains only dependency version bump in go.mod files. No deployment manifests, operator code, or controllers are modified, so topology-aware scheduling check does not apply.
Ote Binary Stdout Contract	✅ Passed	PR updates go.mod dependency (go-jose v4.1.3→v4.1.4). OTE check not applicable: no new process-level code introduced that could violate stdout contract. Existing logging configured correctly.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only updates go-jose v4 dependency version. No new Ginkgo e2e tests are added, so the custom check is not applicable to this PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

bandrade · 2026-05-07T15:27:27Z

/label qe-approved
/verified by @bandrade

openshift-ci-robot · 2026-05-07T15:28:01Z

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-81994, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-84410 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-84410 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-05-07T15:28:07Z

@bandrade: This PR has been marked as verified by @bandrade.

Details

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MrSanketkumar · 2026-05-11T08:21:25Z

/hold since the 4.21 GRPC pkg should be merged first due to a higher-priority CVE.

rissh · 2026-05-12T19:11:01Z

/retitle [Release-4.21] OCPBUGS-81993,OCPBUGS-81994: Bump github.com/go-jose/go-jose/v4 to 4.1.4

openshift-ci-robot · 2026-05-12T19:11:13Z

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-81993, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-81994, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-84410 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-84410 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rissh · 2026-05-12T19:13:22Z

/jira refresh

openshift-ci-robot · 2026-05-12T19:13:32Z

@rissh: This pull request references Jira Issue OCPBUGS-81993, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-84409 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-84409 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

This pull request references Jira Issue OCPBUGS-81994, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-84410 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-84410 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MrSanketkumar · 2026-05-13T06:01:03Z

/hold cancel

MrSanketkumar · 2026-05-13T06:01:42Z

@coderabbitai review

coderabbitai · 2026-05-13T06:01:48Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

openshift-ci-robot · 2026-05-13T06:05:16Z

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-81993, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-84409 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-84409 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

This pull request references Jira Issue OCPBUGS-81994, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-84410 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-84410 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

Summary by CodeRabbit

Chores

Updated a cryptographic library dependency to its latest patch version for improved stability and security.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-05-13T09:42:43Z

@MrSanketkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/tests-extension	`6494c6d`	link	true	`/test tests-extension`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tmshort · 2026-05-13T13:07:43Z

/lgtm
/approve

The go.mod/go.sum files look good. I did not look at vendor files.

openshift-ci · 2026-05-13T13:08:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrSanketkumar, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bandrade · 2026-05-13T13:29:20Z

/label qe-approved
/verified by @bandrade

openshift-ci-robot · 2026-05-13T13:29:34Z

@bandrade: This PR has been marked as verified by @bandrade.

Details

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bandrade · 2026-05-13T13:30:49Z

/label backport-risk-assessed

openshift-ci · 2026-05-13T13:31:49Z

@bandrade: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

prabhapa · 2026-05-14T05:13:05Z

/label backport-risk-assessed

openshift-ci-robot · 2026-05-14T05:17:31Z

@MrSanketkumar: Jira Issue Verification Checks: Jira Issue OCPBUGS-81993
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-81993 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Jira Issue Verification Checks: Jira Issue OCPBUGS-81994
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-81994 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary by CodeRabbit

Chores

Updated a cryptographic library dependency to its latest patch version for improved stability and security.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-05-14T17:45:57Z

Fix included in release 4.21.0-0.nightly-2026-05-14-091301

openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 7, 2026

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 7, 2026

openshift-ci Bot requested review from pedjak and perdasilva May 7, 2026 11:31

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label May 7, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 7, 2026

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2026

openshift-ci Bot changed the title ~~[Release-4.21] OCPBUGS-81994: Bump github.com/go-jose/go-jose/v4 to 4.1.4~~ [Release-4.21] OCPBUGS-81993,OCPBUGS-81994: Bump github.com/go-jose/go-jose/v4 to 4.1.4 May 12, 2026

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2026

openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 12, 2026

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 12, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 12, 2026

MrSanketkumar force-pushed the CVE-2026-34986-4.21 branch from fb641fb to 6494c6d Compare May 13, 2026 06:00

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label May 13, 2026

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2026

UPSTREAM: <carry>:Bump github.com/go-jose/go-jose/v4 to 4.1.4

7746273

MrSanketkumar force-pushed the CVE-2026-34986-4.21 branch from 6494c6d to 7746273 Compare May 13, 2026 06:53

openshift-ci Bot assigned tmshort May 13, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 13, 2026

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 14, 2026

openshift-ci Bot assigned bandrade May 14, 2026

openshift-merge-bot Bot merged commit 9bf1d98 into openshift:release-4.21 May 14, 2026
14 checks passed

Conversation

MrSanketkumar commented May 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented May 7, 2026

Uh oh!

coderabbitai Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Uh oh!

bandrade commented May 7, 2026

Uh oh!

openshift-ci-robot commented May 7, 2026

Uh oh!

openshift-ci-robot commented May 7, 2026

Uh oh!

MrSanketkumar commented May 11, 2026

Uh oh!

rissh commented May 12, 2026

Uh oh!

openshift-ci-robot commented May 12, 2026

Uh oh!

rissh commented May 12, 2026

Uh oh!

openshift-ci-robot commented May 12, 2026

Uh oh!

MrSanketkumar commented May 13, 2026

Uh oh!

MrSanketkumar commented May 13, 2026

Uh oh!

coderabbitai Bot commented May 13, 2026

Uh oh!

openshift-ci-robot commented May 13, 2026

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented May 13, 2026

Uh oh!

tmshort commented May 13, 2026

Uh oh!

openshift-ci Bot commented May 13, 2026

Uh oh!

bandrade commented May 13, 2026

Uh oh!

openshift-ci-robot commented May 13, 2026

Uh oh!

bandrade commented May 13, 2026

Uh oh!

openshift-ci Bot commented May 13, 2026

Uh oh!

prabhapa commented May 14, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented May 14, 2026

Summary by CodeRabbit

Uh oh!

openshift-merge-robot commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MrSanketkumar commented May 7, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 7, 2026 •

edited

Loading